Skip to content

FE-2276: Add toast to DS - #10567

Open
alex-e-leon wants to merge 2 commits into
mainfrom
FE-2276-add-toast-to-ds
Open

alex-e-leon wants to merge 2 commits into
mainfrom
FE-2276-add-toast-to-ds

Conversation

@alex-e-leon

Copy link
Copy Markdown
Contributor

🌟 Purpose

Adds a new Toast component to Salt

@alex-e-leon
alex-e-leon requested a review from a team as a code owner November 20, 2026 14:33
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hash Ready Ready Preview Nov 20, 2026 5:28pm UTC
hashdotdesign-tokens Ready Ready Preview Nov 20, 2026 5:28pm UTC
petrinaut Ready Ready Preview Nov 20, 2026 5:28pm UTC
petrinaut-docs Ready Ready Preview Nov 20, 2026 5:28pm UTC

Request Review

@github-actions github-actions Bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/apps > hash.design Affects the `hash.design` design site (app) labels Nov 20, 2026
@veria-ai

veria-ai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR overview

No security issues were found in this pull request.

Reviews

@cursor

cursor Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
New UI surface with portal stacking, timers, and accessibility contracts; low risk to existing code aside from a small Banner import refactor with no API change.

Overview
Adds Toast and Toaster to @hashintel/ds-components, giving apps transient notifications with Banner-aligned tones (neutral, brand, success, warning, error) and variants (solid, soft, outline).

Apps mount Toaster once, then either render Toast declaratively (with Toast.Title, Toast.Body, Toast.Actions, Toast.Action) or call the imperative toaster API (create, promise, update, close). Behavior includes viewport position stacks, collapsible deep stacks, configurable duration / dismissal, in-place updates by id, and ARIA-oriented regions built on Ark UI / zag.

Banner now imports shared defaultToneIcon from util/default-tone-icon.ts instead of defining it locally. New Storybook stories and MDX docs ship with the component. Package exports and a patch changeset are included.

Reviewed by Cursor Bugbot for commit 899b24c. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@alex-e-leon
alex-e-leon force-pushed the FE-2276-add-toast-to-ds branch from 59d585f to b556087 Compare November 20, 2026 15:45

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e156aea. Configure here.

This branch was successfully deployed

4 active deployments
Preview – hash — 899b24cb Deployed Nov 20, 2026 by vercel[bot]
Preview – petrinaut — 899b24cb Deployed Nov 20, 2026 by vercel[bot]
Preview – hashdotdesign-tokens — 899b24cb Deployed Nov 20, 2026 by vercel[bot]
Preview – petrinaut-docs — 899b24cb Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

1 participant